Open CarlosLopezDeLara opened 3 months ago
The max. supported Protocol-Version is hardcoded into the cardano-cli and cardano-node right? A function to expose that directly via cardano-cli would be super nice yes. Maybe there should be a general new function that shows cardano-cli internals, like this max supported version, minimal supported node-version, etc? Like the query-tip function, but for internals only, not live data. This should all also work offline.
@gitmachtl afaik CLI uses ledger's whatever max version is in the code. It's the node which validates if protocol version used is ok. Relevant PR: https://github.com/IntersectMBO/cardano-node/pull/5820/
@gitmachtl afaik CLI uses ledger's whatever max version is in the code. It's the node which validates if protocol version used is ok. Relevant PR: IntersectMBO/cardano-node#5820
if you try to generate a hardforkcertificate with latest cli, and you try f.e. 12.1, it quits with the following error:
cardano-cli-latest: mkProtocolVersionOrErr: invalid protocol version (12,1)
CallStack (from HasCallStack):
error, called at src/Cardano/CLI/EraBased/Options/Governance/Actions.hs:246:7 in cardano-cli-8.23.1.0-inplace:Cardano.CLI.EraBased.Options.Governance.Actions
calling it with protocol-version like 11.6 works.
so there is also some limitation (maxProtocol) in the cli itself
It uses this value: https://github.com/IntersectMBO/cardano-ledger/blob/master/libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Version.hs#L54 . I guess we can return this as well.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.
What
As an SPO or DREP or CC, after updating my node to the version that supports a specific hardfork, I want to query the node for the maximum protocol version it supports before casting my vote, so that I can confirm it supports the protocol version required by the hardfork.
Why
What if it doesn't? :scream: How do I know?
Acceptance Criteria
When I send a query to the node requesting the maximum protocol version it supports, then:
Personas
Definition of Done (DoD)
Sign-off
Related PRs