Closed smelc closed 2 weeks ago
So what we really want is a top level command that can hash all the hashable things. Or at least not to give the impression that hashing depends on the era.
cc @CarlosLopezDeLara since the current design is your ask from https://github.com/IntersectMBO/cardano-cli/issues/782
I can make hash
a top-level command if you approve that like @Jimbo4350 does
@smelc I like the idea! sounds great.
@Jimbo4350> Made the command top-level and removed the era.
I will consider in a follow-up PR if other hashing commands can be moved there too (hashing keys).
LGTM! However I would be wary of breaking the existing hashing functionality. Talk to @CarlosLopezDeLara about this as it may be an annoying for users who have existing scripts etc.
I think we can afford the breaking change here since 9.0 is still in the makings and 8.12 will not cross the hardfork. I'll update docs after this is on a cardano-cli release.
@smelc there are a lot of leftovers in the help texts like:
...
--anchor-data-hash HASH Proposal anchor data hash (obtain it with
"cardano-cli conway governance hash anchor-data ...")
--constitution-url TEXT Constitution URL.
--constitution-hash HASH Hash of the constitution data (obtain it with
"cardano-cli conway governance hash anchor-data
...").
...
pointing to the old location of the hash function conway governance hash
@gitmachtl> yes, it's being fixed by https://github.com/IntersectMBO/cardano-cli/pull/821. I think that's because I I lost some of my changes while polishing the PR :frowning_face:
Changelog
Context
Fixes https://github.com/IntersectMBO/cardano-cli/issues/782