- description: |
Remove check of Drep metadata size, always return the hash of the file passed by the user. This to be compatible with CIP119.
Upgrade cardano-api-9.1.0.0
# uncomment types applicable to the change:
type:
- feature # introduces a new feature
- breaking # the API has changed in a breaking way
# - compatible # the API has changed but is non-breaking
# - optimisation # measurable performance improvements
# - refactoring # QoL changes
# - bugfix # fixes a defect
# - test # fixes/modifies tests
# - maintenance # not directly related to the code
# - release # related to a new release preparation
# - documentation # change in code docs, haddocks...
cardano-cli conway governance drep metadata-hash --drep-metadata-file drep.jsonld
Command failed: governance drep metadata-hash Error: DRep metadata validation error: DRep metadata must consist of at most 512 bytes, but it consists of 178103 bytes.
With this PR we always return the hash and the resulting hash matches the one on the test vector of CIP-119 AND matches the hash obtained with governance hash anchor-data AND matches the result of using blake2b directly:
FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch that you can find in my previous comment in this PR.
Changelog
Context
Resolves: https://github.com/IntersectMBO/cardano-cli/issues/792 Depends on: https://github.com/IntersectMBO/cardano-api/pull/569 which is not on the tagged cardano-api-9.0.0.0 . Therefore this requires a new release of cardano-api.
How to trust this PR
Before this PR we had:
With this PR we always return the hash and the resulting hash matches the one on the test vector of CIP-119 AND matches the hash obtained with
governance hash anchor-data
AND matches the result of using blake2b directly:Checklist