IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
39 stars 14 forks source link

Fix treasury withdrawal. #877

Closed CarlosLopezDeLara closed 2 weeks ago

CarlosLopezDeLara commented 2 weeks ago

Changelog

- description: |
    Make funds receiving address and amount mandatory. 
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
   - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Resolves https://github.com/IntersectMBO/cardano-cli/issues/876

How to trust this PR

Now, creating the proposal fails if there is no receiving address supplied.

cardano-cli conway governance action create-treasury-withdrawal --testnet \
--governance-action-deposit 100000000000 \
--deposit-return-stake-script-file keys/stake-multisig.json \
--anchor-url https://tinyurl.com/3wrwb2as \
--anchor-data-hash 52e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2 \
--out-file transactions/treasury-no-receive-address.action

Missing: (
    ( --funds-receiving-stake-verification-key STRING
    | --funds-receiving-stake-verification-key-file FILE
    | --funds-receiving-stake-key-hash HASH
    )
    --transfer LOVELACE)

Usage: cardano-cli conway governance action create-treasury-withdrawal

Checklist