search

IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
39 stars 14 forks source link

Remove eras older than Babbage support in `transaction build` and `transaction build-estimate` #878

Open carbolymer opened 2 weeks ago

carbolymer commented 2 weeks ago

Changelog

- description: |
    Remove eras older than Babbage support in `transaction build` and `transaction build-estimate`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
   - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Requires cardano-api with:

Checklist

gitmachtl commented 1 week ago

would this affect the build-raw command in any way? it should still be possible to do all things with build-raw imo.

carbolymer commented 1 week ago

@gitmachtl no it's only for build and build-estimate. You can see which commands are removed here: https://github.com/IntersectMBO/cardano-cli/pull/878/files?file-filters%5B%5D=.cli&show-deleted-files=true&show-viewed-files=true&w=1 build-raw stays the same as it was.

gitmachtl commented 6 days ago

one question, so in the future if will not be possible to generate "shelley-era" style transactions anymore if you just wanna send lovelaces around, right?

Jimbo4350 commented 5 days ago

one question, so in the future if will not be possible to generate "shelley-era" style transactions anymore if you just wanna send lovelaces around, right?

We will expose a transaction building command that will be parameterized on the era. Currently it will only be able to spend tx inputs and accept update proposals. This is for our QA team to test hardforks from Byron -> $currentEra.