IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
39 stars 14 forks source link

[FEATURE] - extend drep id cmd so that it returns id in hex and bech32 for script based dreps. Use CIP105 #883

Open CarlosLopezDeLara opened 1 week ago

CarlosLopezDeLara commented 1 week ago

What

Extend cardano-cli conway drep id so that it returns drep id in hex and bech32 also for script based dreps.

We should use Use CIP105 so that the prefix for script based dreps should be drep_script

Why

Personas

Definition of Done (DoD)

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch. So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

Related PRs

  1. PR # here

Acceptance Criteria

Acceptance Criteria & User Stories define here (or in a separate file (linked here) for a big feature)

Example - https://github.com/input-output-hk/cardano-node/issues/4453

smelc commented 1 week ago

@CarlosLopezDeLara> something we can work on together maybe?