IntersectMBO / cardano-cli

This repository contains sources for the command-line interface (CLI) tool for interacting with the Cardano blockchain.
Apache License 2.0
44 stars 15 forks source link

[FEATURE] - Update stake-address-info to show all types of deposits: drep deposit, action deposit, pool deposits #954

Open CarlosLopezDeLara opened 1 month ago

CarlosLopezDeLara commented 1 month ago

What

Update query stake-address-info so that it returns all possible deposits associated to the stake address, not only stake address registration, but also "governance action deposits".

Why

This is useful information for users and should be easily accessible. This helps users to know if it is "safe" for them to deregister an stake address. i.e. there are no pending pool, drep or governance action deposits.

Personas

Definition of Done (DoD)

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch. So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

Related PRs

  1. PR # here

Acceptance Criteria

gitmachtl commented 1 month ago

@CarlosLopezDeLara drepDeposit is not living on the stake account. its stored in the ledger yes, but will be paid out directly to the payment address of the deregistration certificate transaction. so i think you can remove this entry from your proposed output.