Here the QuickCheck bug actually revelaed a real issue. That makes me think we should split these tests between actually flaky generators (that are just legitimately difficult to satisfy so will fail some small % of the time) and generators that ought never fail.
Checklist
[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[x] The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
Description
Here the QuickCheck bug actually revelaed a real issue. That makes me think we should split these tests between actually flaky generators (that are just legitimately difficult to satisfy so will fail some small % of the time) and generators that ought never fail.
Checklist
.cabal
andCHANGELOG.md
files according to the versioning process..cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)