Closed lehins closed 3 months ago
The only thing that I wonder about this is is: how come this check is in Ledger
I didn't really think too much which rule this check should go into, but since you bring it up, I believe LEDGER is a good home for it, because it doesn't check any individual reference script, but rather their total size. In other words MalformedReferenceScripts
or OutputTooBigUTxO
check validity of individual components of a transaction, while ConwayTxRefScritpsSizeTooBig
is a check on a transaction level.
In general location of this type of checks is very subjective. I am not sure why, for example ConwayWdrlNotDelegatedToDRep
and ConwayTreasuryValueMismatch
are defined in LEDGER either :shrug: Probably has to do with parts of the state they need to access, rather than with anything else.
Description
This PR does two things:
ConwayTreasuryValueMismatch
predicate check into the section that validatesisValid == True
transactions. There is no need to validate this value for phase2 failed transactions.Checklist
.cabal
andCHANGELOG.md
files according to the versioning process..cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)