IntersectMBO / cardano-ledger

The ledger implementation and specifications of the Cardano blockchain.
Apache License 2.0
262 stars 155 forks source link

Add a new predicate failure for non-matching withdrawals #4640

Open lehins opened 2 months ago

lehins commented 2 months ago

Current predicate failure that checks whether withdrawal matches the amount in the reward account is totally misleading. It is reported as WithdrawalsNotInRewardsCERTS, which is also the predicate failure that is used for reporting non-existent reward accounts. We need to create proper predicate failure for that and also fix the name and refactor validateZeroRewards function, cause that is even more misleading.

lehins commented 1 month ago

This has been postponed until next era, unless we decide that we will have another intra-era hardfork that advances Conway era to PV11