and run withdrawal tests for both bootstrap and post-bootstrap
While reviewing Aniket's PR, I realized that in my previous PR, i have changed the behavior of empty withdrawals happening during bootstrap, by returning an extra predicate failure, which breaks node-to-client protocol.
This PR is changing that, ensuring that during bootstrap the new predicate failure is omitted, and also makes sure that withdrawal tests are executing for both protocol versions of Conway, to make sure that the predicate failures during bootstrap are kept unchanged.
Description
Checklist
[ ] Commit sequence broadly makes sense and commits have useful messages
[ ] New tests are added if needed and existing tests are updated
[ ] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
New section is never added with the code changes. (See RELEASING.md)
[ ] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated.
If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
and run withdrawal tests for both bootstrap and post-bootstrap
While reviewing Aniket's PR, I realized that in my previous PR, i have changed the behavior of empty withdrawals happening during bootstrap, by returning an extra predicate failure, which breaks node-to-client protocol.
This PR is changing that, ensuring that during bootstrap the new predicate failure is omitted, and also makes sure that withdrawal tests are executing for both protocol versions of Conway, to make sure that the predicate failures during bootstrap are kept unchanged.
Description
Checklist
CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md).cabalandCHANGELOG.mdfiles according to the versioning process..cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)