IntersectMBO / cardano-ledger

The ledger implementation and specifications of the Cardano blockchain.
Apache License 2.0
262 stars 155 forks source link

Enforce Cabal dependency in byron package #4682

Closed teodanciu closed 1 month ago

teodanciu commented 1 month ago

in order to avoid an error when releasing the package

Description

Checklist

To prevent this error in the Chap build:

   > Configuring library for cabal-doctest-1.0.10..
   > Error:
   >     The following packages are broken because other packages they depend on are missing. These broken packages must be rebuilt before they can be used.
   > installed package Cabal-3.2.1.0 is broken due to missing package parsec-3.1.14.0, text-1.2.4.1
   >
   For full logs, run 'nix log /nix/store/r6jgcm89wc2czyqmwggjlycb56kdhk4k-cabal-doctest-lib-cabal-doctest-1.0.10.drv'.

error: 1 dependencies of derivation '/nix/store/672afr0iq9qnfxpv42pb1jv7a3ih5b12-pretty-simple-4.1.2.0-setup.drv' failed to build building '/nix/store/hp9m0cfxc3h0fpa836k43nhkwjwmvzcl-call-stack-lib-call-stack-0.4.0.drv'... error: 1 dependencies of derivation '/nix/store/s5hcv2p2bjmz9dndx13qz2ljg9mgj91x-pretty-simple-lib-pretty-simple-4.1.2.0.drv' failed to build error: 1 dependencies of derivation '/nix/store/a9ys8di4hdv91z78x24313cihpn0vi5n-ouroboros-consensus-lib-unstable-consensus-testlib-0.20.1.0.drv' failed to build error: 1 dependencies of derivation '/nix/store/qykliwqawv67lsck80pwzi2bg4wg0i1h-ouroboros-network-testing-lib-ouroboros-network-testing-0.7.0.0.drv' failed to build error: 1 dependencies of derivation '/nix/store/d2bgl2kmiq84bj3yq8i8nnkkgy1d84bb-ouroboros-consensus-cardano-lib-unstable-byron-testlib-0.19.0.0.drv' failed to build

Lucsanszky commented 1 month ago

We can do this as a revision in cardano-haskell-packages. I'll add the changes to your open PR there and if it works out, we can close this.

Lucsanszky commented 1 month ago

https://github.com/IntersectMBO/cardano-haskell-packages/pull/925 now builds with the revision, so this PR won't be needed. Closing.