This PR fixes two bugs that where introduced in #4652:
Delegating to an SPO by a stake credential that was already delegated to a DRep violated the internal invariant leading to an inconsistency in which upon this DRep unregistration the delegation would not get cleaned up. Thus it would lead to a way to surpass the protection of delegation to a non-registered DRep
For testing and benchmarking we have ability to inject DReps and their delegations through the Genesis file. This injection was broken for DReps, since it did not maintain the internal invariant of DRep delegations
Checklist
[x] Commit sequence broadly makes sense and commits have useful messages
[x] New tests are added if needed and existing tests are updated
[x] All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
New section is never added with the code changes. (See RELEASING.md)
[x] When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
versioning process.
[ ] The version bounds in .cabal files for all affected packages are updated.
If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
[x] Code is formatted with fourmolu (use scripts/fourmolize.sh)
[x] Cabal files are formatted (use scripts/cabal-format.sh)
[x] hie.yaml has been updated (use scripts/gen-hie.sh)
Description
This PR fixes two bugs that where introduced in #4652:
Checklist
CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md).cabalandCHANGELOG.mdfiles according to the versioning process..cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)