search

IntersectMBO / cardano-node

The core component that is used to participate in a Cardano decentralised blockchain.
https://cardano.org
Apache License 2.0
3.06k stars 721 forks source link

[FR] - When reading the genesis files, Mac and Windows newlines should be blindly converted to sane ones #4959

Open erikd opened 1 year ago

erikd commented 1 year ago

This would prevent hash match failures in the test code and remove the need for

> cat .gitattributes 
# GitHub Linguist annotations.

configuration/cardano/mainnet-config.json text eol=lf
configuration/cardano/mainnet-alonzo-genesis.json text eol=lf
configuration/cardano/mainnet-byron-genesis.json text eol=lf
configuration/cardano/mainnet-conway-genesis.json text eol=lf
configuration/cardano/mainnet-shelley-genesis.json text eol=lf

When complete. it should be possible to delete the above .gitattributes entries and still have the tests pass on Mac and Windows.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

newhoggy commented 1 year ago

Still relevant