Closed aleeusgr closed 2 months ago
@aleeusgr Can you sign your commits please? That's our requirement for all changes in the node. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
@carbolymer hello!
I am confused a bit, I did the following:
git commit --amend --signoff
git push origin add-toplevel-changelog -f
now the commit message contains my name and email, does it mean its signed?
Thank you!
now the commit message contains my name and email, does it mean its signed
git log --format=raw
show the log in the raw format which includes a crypto signing block.
Thanks! It was not signed, I fixed my git and now It looks signed.
@aleeusgr I think you just need to upload your public key to github
@carbolymer thanks!
Added GPG key to my GitHub account.
KeyID: 6A7D30C3EFF7B815
Description
Add your description here, if it fixes a particular issue please provide a link to the issue.
closes #5874
Checklist
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons. You will need to get someone with write privileges. Please contact IOG node developers to do this for you.