IntersectMBO / cardano-node

The core component that is used to participate in a Cardano decentralised blockchain.
https://cardano.org
Apache License 2.0
3.07k stars 720 forks source link

add toplevel changelog #5959

Closed aleeusgr closed 2 months ago

aleeusgr commented 3 months ago

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

closes #5874

Checklist

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons. You will need to get someone with write privileges. Please contact IOG node developers to do this for you.

carbolymer commented 2 months ago

@aleeusgr Can you sign your commits please? That's our requirement for all changes in the node. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

aleeusgr commented 2 months ago

@carbolymer hello!

I am confused a bit, I did the following: git commit --amend --signoff git push origin add-toplevel-changelog -f

now the commit message contains my name and email, does it mean its signed?

Thank you!

erikd commented 2 months ago

now the commit message contains my name and email, does it mean its signed

git log --format=raw show the log in the raw format which includes a crypto signing block.

aleeusgr commented 2 months ago

Thanks! It was not signed, I fixed my git and now It looks signed.

carbolymer commented 2 months ago

@aleeusgr I think you just need to upload your public key to github image

aleeusgr commented 2 months ago

@carbolymer thanks!

Added GPG key to my GitHub account.

KeyID: 6A7D30C3EFF7B815