IntersectMBO / cardano-node

The core component that is used to participate in a Cardano decentralised blockchain.

https://cardano.org

Apache License 2.0

3.07k stars 720 forks source link

cardano-testnet-test: small improvements #5962

Closed smelc closed 2 months ago

smelc commented 2 months ago

Description

This PR removes initialization of fields in cardano-testnet-test that were useless because they were initializing said fields with the same value as the default values. It also does QoL improvements.

Checklist

[X] Commit sequence broadly makes sense and commits have useful messages
[X] Self-reviewed the diff

coot commented 2 months ago

Are we using P2P stack in tests? Note that the non-p2p stack will be removed at some point.

smelc commented 2 months ago

@coot> I believe we don't use P2p in cardano-testnet, because here is what we have by default in the configuration.yaml used to start nodes:

→ cat /tmp/nix-shell.3H7AVw/cli-queries-test-23d51bd100cd79ee/configuration.yaml  | grep P2P
    "EnableP2P": false,

smelc commented 2 months ago

Let me amend the PR then, to keep the flag then and honor it instead of doing nothing with it :slightly_smiling_face:

smelc commented 2 months ago

Honoring P2P will affect other work I have stacked on this one, so I'll just keep the "small improvements" bits of this PR and merge. P2P honoring will come later.

coot commented 2 months ago

Note that non-p2p will be removed.