Open gitmachtl opened 9 months ago
Thanks, @gitmachtl, yes! what you see is still a WIP we are migrating stuff from internal docs to this GH repo. I think we will complete this migration within the next couple of days. The voltaire team is focusing on gov-tools section; Me and Noel are working on the cli stuff.
Apart of "CLI accepts keys generated from 3rd party tools", the rest of your suggestions will be covered on the SystemLevel/CIP1694 section, which we'll work after we finish CLI ones.
@CarlosLopezDeLara thx! With the "3rd party tool" keys, i was thinking about the definitions from the CIP105. So that cardano-cli will also work with derived keys like that.
Hey, i took a look at the current tests. Not sure whats already in planning, but just a few quick thoughts:
Shouldn't there be also tests for general changes in the conway era?
For example:
Also there are currently no vote related tests listed, which should also include all the new possible voteDelegation methods (https://github.com/input-output-hk/cardano-ledger/blob/bcf6051f4a0b69c82e4de7327d7d8801fa1bad87/eras/conway/impl/cddl-files/conway.cddl#L305-L309).
General tests on thresholds set via the genesis file, are they reached before executed/accepted?
Should there also be tests that the CLI accepts keys generated from 3rd party tools, but following the CIP105 (https://github.com/cardano-foundation/CIPs/tree/master/CIP-0105) key specifications? Which includes also derived keys like:
Should tests related to HW-Wallets and Conway things like dRep-Key generation, etc. also be included in the tests or is this out of scope because of 3rd party tools?
Best regards, Martin