search

IntersectMBO / cardano-transactions

Library utilities for constructing and signing Cardano transactions.
Apache License 2.0
25 stars 7 forks source link

Add support for Shelley txs #16

Open paweljakubas opened 4 years ago

paweljakubas commented 4 years ago

We want to be able to produce Shelley compliant signed transaction blob

piotr-iohk commented 3 years ago

It seems that add-output does not support bech32 addresses.... :thinking: 

cardano-tx empty 1097911063 \
>   | cardano-tx add-input 1 29657703d662e9c36845c2f61505e96e92128605ff9eb4b635ec659ed4998625 \
>   | cardano-tx add-output 1000000 addr1qqlgm2dh3vpv07cjfcyuu6vhaqhf8998qcx6s8ucpkly6f8l0dw5r75vk42mv3ykq8vyjeaanvpytg79xqzymqy5acmqej0mk7 

cannot parse value `addr1qqlgm2dh3vpv07cjfcyuu6vhaqhf8998qcx6s8ucpkly6f8l0dw5r75vk42mv3ykq8vyjeaanvpytg79xqzymqy5acmqej0mk7'

I suppose we need to add them to have support for shelley tx in cardano-tx.

piotr-iohk commented 3 years ago

I have updated https://github.com/input-output-hk/cardano-transactions/wiki/How-to-submit-transaction-via-cardano-tx-CLI to be up-to-date with recent changes.

Unfortunately trying to follow this "example" :point_up_2: I am getting error on submitting the transaction via cardano-wallet...

cardano-wallet transaction submit 82839f8200d818582482582029657703d662e9c36845c2f61505e96e92128605ff9eb4b635ec659ed499862501ff9f8282d818582883581c8011d974e8746a3b83cf145cde56b0053ad3fbe6dc62c5ab97f42309a102451a4170cb17001afb04e5681a000f42408282d818582883581c7e708fd52abd2263f453c0a4fdc4713a024f33fcd0acd25f058a01cda102451a4170cb17001a212741771a0086bd17ffa0818200d818588582584065eca1dee6ba9b2ef4c8515d430d800e9a2e4628062083da3f3c327eb0dccc2410723b6c2ab4b18feffe6931140d1d2ecfeb6a28ea6f0ec9fe6a5e9ac4838fd0584093f745130999ab80411b5899a39358ff3bebe470952d222b0f394bb169e1effef06587e92b38276542684583dc0eef6a9cee5acf8d1d491535dd841c5eaf5209

I couldn't verify that the payload has the correct binary format. 
Therefore I couldn't send it to the node. Please check the format and try again.
KtorZ commented 3 years ago

@piotr-iohk we haven't yet updated the command-line on cardano-tx to be Shelley compatible :/

piotr-iohk commented 3 years ago

@KtorZ , looking at the acceptance criteria of https://jira.iohk.io/browse/ADP-396:

One can create a Shelley era transaction blob using cardano-transactions and send it via /proxy/transactions endpoint in cardano-wallet.

Currently makes it impossible from the CLI level due to:

a) https://github.com/input-output-hk/cardano-transactions/issues/16#issuecomment-701349759 (cardano-tx not supporting bech32) b) https://github.com/input-output-hk/cardano-transactions/issues/16#issuecomment-701433948 (cannot send anything via POST /proxy/transacionts) (I was actually trying to run https://github.com/input-output-hk/cardano-transactions/wiki/How-to-submit-transaction-via-cardano-tx-CLI for Shelley, Icarus and Byron random wallet (updated the document for all cases)... every time I get the same result at the end)

I couldn't verify that the payload has the correct binary format. 
Therefore I couldn't send it to the node. Please check the format and try again.

I think we either put it back to in progress or close this one and create bug tickets for the above to track it. Let me know. :)

KtorZ commented 3 years ago

Definitely back in progress :)