search

IntersectMBO / cardano-transactions

Library utilities for constructing and signing Cardano transactions.
Apache License 2.0
25 stars 7 forks source link

bump to 1.20.0 node dependencies #20

Closed paweljakubas closed 3 years ago

hasufell commented 3 years ago

@paweljakubas did you see my comment?

paweljakubas commented 3 years ago

@hasufell oh, sorry, PR approve went to me and I automatically merge it...

Frankly speaking I tried here to comply with practice we use in other repos, like cardano-wallet, cardano-addresses.... Maybe it is good idea to pursue the approach you recommend, first discuss it in our Slack channel, and then adopt in all repos at once to have this level consistency? What do you think? I do not feel expert in those things and always try to comply with pattern used in other repos

@KtorZ @rvl what are your opinions here?

hasufell commented 3 years ago

I don't have a strong opinion. I might just fork stack2cabal anyway, since upstream isn't very active.

rvl commented 3 years ago

I suspect that the real objection to resolver URLs is that stack2cabal doesn't work with them and the other reasons are just padding.