search

IntersectMBO / cardano-transactions

Library utilities for constructing and signing Cardano transactions.
Apache License 2.0
25 stars 7 forks source link

Fix CI style check errors #25

Closed rvl closed 3 years ago

rvl commented 3 years ago

stylish-haskell in GitHub actions does not appear to use the config file in this repo.

This attempts to fix it by using v0.11.0.0.

KtorZ commented 3 years ago

@rvl the problem is a "recent" bump in stylish-haskell few weeks ago which isn't compatible with the configuration we use. I tried upgrading once (one day after the new release) but there were bugs only present in this new release with regards to the imports alignment. I haven't checked whether that bug had been fixed and resorted to slightly "fork" and modify the stylish-haskell script to accept a version number (otherwise, it just goes for the latest version released on the stylish-haskell repository).

See it here:

https://github.com/input-output-hk/adrestia/blob/master/.haskell/stylish-haskell.sh

and used here:

https://github.com/input-output-hk/cardano-addresses/blob/master/.github/workflows/style.yml

rvl commented 3 years ago

Aha - that's it, thanks. Seems to work now.

I could not reproduce the problem locally though, not sure why.