IntersectMBO / formal-ledger-specifications

Formal specifications of the cardano ledger
Apache License 2.0
38 stars 13 forks source link

document: new/update committee specs #477

Closed ashisherc closed 5 months ago

ashisherc commented 5 months ago

1 - there is an irregularity between the ledger spec and CDDL regarding the new committee gov action naming, CDDL specifies update_committee while the ledger spec refers to it as NewCommittee

2 - please document details regarding creating and updating committee members,

update_committee = (4, gov_action_id / null, set<committee_cold_credential>, { committee_cold_credential => epoch_no }, unit_interval)

Specifics of update_committee gov action will be constructive.

WhatisRT commented 5 months ago
  1. We need to decide what the name should be, I'll talk to the relevant people about that.
  2. Note that there's an explanation for NewCommittee in the spec:

    changes to the members of the constitutional committee and/or to its signature threshold and/or terms

    All the questions questions about details should be answered by looking at GOV/ENACT/RATIFY. The first map adds members with an expiration epoch, the second one removes members and nothing special happens if any of those are empty.

ashisherc commented 5 months ago
The first map adds members with an expiration epoch, the second one removes members and nothing special happens if any of those are empty.

@WhatisRT I think you mean first set to remove members and second map to add members with expiry. Could this please be documented in the ledger spec.

WhatisRT commented 5 months ago

I don't know why the CDDL has the arguments in another order, but I was referring to the arguments in the order they appear in the spec.

ashisherc commented 5 months ago

@WhatisRT might require the change of order in the spec, CDDL order seems correct (afaik)