Open kneerose opened 3 months ago
OK - found id:
Delegation Page: (Mention on https://github.com/IntersectMBO/govtool/issues/1038 )
signal-no-confidence-card. abstain-delegation-card.
FOUND Element: DIV data-testid: no-confidence-delegation-card
Element: DIV data-testid: abstain-delegation-card
OK for DRep registration: "email-input and link-input are incorrectly placed. The data-testid should be inside the input tag." - in input now
Element: INPUT data-testid: drep-name-input
Element: INPUT data-testid: email-input
Element: TEXTAREA data-testid: bio-input
Element: P data-testid: some-sentence-about-yourself-error
Element: INPUT data-testid: link-1-input
OK - on Drep Registration - Download button:
Element: BUTTON data-testid: metadata-download-button like this:
<button class="MuiButtonBase-root MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary css-nkeny4" tabindex="0"
type="button" data-testid="metadata-download-button">
test.jsonld
OK for - Missing test Id on DRep Card
DRep card -> test id = drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-drep-card
data-testid: drep1pzuxy8ukuvffjyyrdp8sxkzp3z8r57z5q0jtgxhwu3a22t9ppel-drep-card jam-console-devtools.js:1
Element: P data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-voting-power-label
Element: P data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-voting-power
status -> test id = status
data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-st
Delegated DRep card -> test id = drep14px384j0j20psnezaf95yppvsqh9hnu73yxpv87yugzujn97t9y-delegated-card
Element: DIV data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-delegated-card
OK NOW for Missing voting power test id on drep details
Element: P data-testid: voting-power
OK - found : Missing test IDs on edit DRep info
add-link-button for the "Add Link" button. Element: BUTTON jam-console-devtools.js:1 data-testid: add-link-button
name-input for the name input field. Element: INPUT data-testid: drep-name-input
email-input for the email input field. Element: INPUT data-testid: email-input
bio-input for the bio input field. Element: TEXTAREA data-testid: bio-input
link-input for the link input field. Element: INPUT
OK for missing voting power test id on dashboard
Element: P jam-console-devtools.js:1 data-testid: voting-power-chips-value
@kneerose found all mentioned test id - take look and let us know how they work
Hi @pmbinapps ,
It seems like you've made changes to the test IDs for other components:
While I appreciate the improvements, could you please avoid changing previously assigned test IDs? Our tests are failing because of these modifications.
@NabinKawan I guess there could be so duplicate, thus that change. @Sworzen1 please correct if I'm wrong.
Hey @Sworzen1
NOT OK: bio-input is still not set @Sworzen1
OK NOW on dev-sancho with bio-input
Hi @pmbinapps, Can we close this related issue after merging it into the test branch? We still cannot verify it.
Hello @pmbinapps ,
Some components still have missing test IDs. I have listed all the missing and incorrect test IDs below. Please confirm and update them accordingly.
continue-button
which is not correctmetadata-url-input
undefinedinput
is taking@MSzalowski any update on this ?
The missing test IDs are crucial as they can make some tests flaky, especially the metadata button test for editDRep. Currently, we are locating the button by testId using page.getByRole("button", { name:
${newDRepName}.jsonld}).click();
. If newDRepName
has more characters than expected, it can cause the test to fail to locate the button.
Therefore, it is necessary to add test IDs to fix the flaky test. Here are some flaky tests related to this issue:
@jdyczka any update on this?
Description:
This ticket is a subtask of parent ticket #937.
Missing Test Ids
Delegation Page: (Mention on #1038 )
signal-no-confidence-card.
abstain-delegation-card.
DRep registration
Incorrect Test ID Path on DRep Form: The test IDs for email-input and link-input are incorrectly placed. The data-testid should be inside the input tag.
The data-testid should be moved to the input tag for proper identification and testing.
Missing test ID for metadata URL (should be testId = metadata-url)
Missing test Id on DRep Card
Delegated DRep card -> test id = drep14px384j0j20psnezaf95yppvsqh9hnu73yxpv87yugzujn97t9y-delegated-card
Missing voting power test id on drep details
Missing test IDs on edit DRep info
missing voting power test id on dashboard
Important: Please ensure to add proper test IDs for all interactive elements to facilitate testing and automation.