[BUG] Missing Test IDs (Drep Directory)

[kneerose]

Description:

• This ticket is a subtask of parent ticket #937.

  Missing Test Ids

  Delegation Page: (Mention on #1038 )

• signal-no-confidence-card.

• abstain-delegation-card.

DRep registration

• Incorrect Test ID Path on DRep Form: The test IDs for email-input and link-input are incorrectly placed. The data-testid should be inside the input tag.

  <div data-testid="email-input" class="MuiInputBase-root MuiInputBase-colorPrimary css-1di96g7">
  <input id=":r16:" name="email" placeholder="john.smith@email.com" type="text" class="MuiInputBase-input css-mevgbx" value="" data-dashlane-rid="92c37e5aa4443fee" data-kwimpalastatus="alive" data-kwimpalaid="1715918960562-0" data-form-type="email">
  </div>

  The data-testid should be moved to the input tag for proper identification and testing.

• Missing test ID for metadata URL (should be testId = metadata-url)

• missing test-id on metadata-download-button

• Missing test Id on DRep Card

  • DRep card -> test id = drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-drep-card
  • voting power -> test id = voting-power
  • status -> test id = status

  • Delegated DRep card -> test id = drep14px384j0j20psnezaf95yppvsqh9hnu73yxpv87yugzujn97t9y-delegated-card

    

• Missing voting power test id on drep details

  

• Missing test IDs on edit DRep info

  • add-link-button for the "Add Link" button.
  • name-input for the name input field.
  • email-input for the email input field.
  • bio-input for the bio input field.
  • link-input for the link input field.

• missing voting power test id on dashboard

  

Important: Please ensure to add proper test IDs for all interactive elements to facilitate testing and automation.

[pmbinapps]

OK - found id:

Delegation Page: (Mention on https://github.com/IntersectMBO/govtool/issues/1038 )

signal-no-confidence-card. abstain-delegation-card.

FOUND Element: DIV data-testid: no-confidence-delegation-card

Element: DIV data-testid: abstain-delegation-card

OK for DRep registration: "email-input and link-input are incorrectly placed. The data-testid should be inside the input tag." - in input now

Element: INPUT data-testid: drep-name-input

Element: INPUT data-testid: email-input

Element: TEXTAREA data-testid: bio-input

Element: P data-testid: some-sentence-about-yourself-error

Element: INPUT data-testid: link-1-input

OK - on Drep Registration - Download button:

Element: BUTTON data-testid: metadata-download-button like this:

<button class="MuiButtonBase-root MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary css-nkeny4" tabindex="0"

type="button" data-testid="metadata-download-button">

test.jsonld

[pmbinapps]

OK for - Missing test Id on DRep Card

DRep card -> test id = drep1qzw234c0ly8csamxf8hrhfahvzwpllh2ckuzzvl38d22wwxxquu-drep-card

data-testid: drep1pzuxy8ukuvffjyyrdp8sxkzp3z8r57z5q0jtgxhwu3a22t9ppel-drep-card jam-console-devtools.js:1

• voting power -> test id = voting-power:

Element: P data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-voting-power-label

Element: P data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-voting-power

status -> test id = status

data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-st

Delegated DRep card -> test id = drep14px384j0j20psnezaf95yppvsqh9hnu73yxpv87yugzujn97t9y-delegated-card

Element: DIV data-testid: drep1qzts73jthmvqjee2m0x7jqm8snn0ycqxcduf9xqec2n3x3u6ge9-delegated-card

[pmbinapps]

OK NOW for Missing voting power test id on drep details

Element: P data-testid: voting-power

OK - found : Missing test IDs on edit DRep info

add-link-button for the "Add Link" button. Element: BUTTON jam-console-devtools.js:1 data-testid: add-link-button

name-input for the name input field. Element: INPUT data-testid: drep-name-input

email-input for the email input field. Element: INPUT data-testid: email-input

bio-input for the bio input field. Element: TEXTAREA data-testid: bio-input

link-input for the link input field. Element: INPUT

OK for missing voting power test id on dashboard

Element: P jam-console-devtools.js:1 data-testid: voting-power-chips-value

[pmbinapps]

@kneerose found all mentioned test id - take look and let us know how they work

[kneerose]

Hi @pmbinapps ,

It seems like you've made changes to the test IDs for other components:

• name-input is now drep-name-input
• link-input is now link-number-input (with a number that increases when adding links)

While I appreciate the improvements, could you please avoid changing previously assigned test IDs? Our tests are failing because of these modifications.

[pmbinapps]

@NabinKawan I guess there could be so duplicate, thus that change. @Sworzen1 please correct if I'm wrong.

[kneerose]

Hey @Sworzen1

• It looks like you've changed the code, replacing drep-name-input with name-input. However, this change also removes the bio-input testid, which causes the test to fail.
• For reference, your PR

[pmbinapps]

NOT OK: bio-input is still not set @Sworzen1

[pmbinapps]

OK NOW on dev-sancho with bio-input

[NabinKawan]

Hi @pmbinapps, Can we close this related issue after merging it into the test branch? We still cannot verify it.

[kneerose]

Hello @pmbinapps ,

Some components still have missing test IDs. I have listed all the missing and incorrect test IDs below. Please confirm and update them accordingly.

1. Edit dRep Info Information Storage Steps
   • Currently the submit button has testID continue-button which is not correct
   • I have mentioned the test IDs in the image below

2. Missing test IDs on inProgress chip
   • Please add test IDs to all "In Progress" chips that will display while the transaction is in progress.

3. Learn More Button
   • Make the test ID for the "Learn More" button unique.
   • Please ensure it on the connected and disconnected state

4. Governance Action Provide Context Update
   • Some test IDs are missing or incorrect. Please review and update them.
   • Here instead of metadata-url-input undefinedinput is taking

[kneerose]

@MSzalowski any update on this ?

[kneerose]

The missing test IDs are crucial as they can make some tests flaky, especially the metadata button test for editDRep. Currently, we are locating the button by testId using page.getByRole("button", { name:${newDRepName}.jsonld}).click();. If newDRepName has more characters than expected, it can cause the test to fail to locate the button.

Therefore, it is necessary to add test IDs to fix the flaky test. Here are some flaky tests related to this issue:

1. Test Report 1
2. Test Report 2
3. Test Report 3

[kneerose]

@jdyczka any update on this?