[BUG] Missing test ids on Create a governance action

kneerose commented 3 weeks ago

Description:

Several components across various pages lack proper test IDs, impeding effective testing and automation.
some of the test IDs are mentioned in (issue #1070)

Missing test IDs

show-all-button for show all
draft-${draft_id}-card for each draft card
draft-${draft_id}-start-editing for each draft start editing button
save-draft-button for save draft

Important: Please ensure to add proper test IDs as defined on previous proposal submission flow

bosko-m commented 3 weeks ago

@vpaunovic @teske00 Is this in progress then?

vpaunovic commented 3 weeks ago

@bosko-m this is already done. Just, it is not yet in NPM package. Its in our repo on main branch. When we update our NPM package, and @MSzalowski update our PDF NPM package with that new version, it will be available there in current govtool.

pmbinapps commented 3 weeks ago

See only these ones on dev-sancho now:

A text: || data-testid: logo-button VM658:26 A text: |Dashboard| data-testid: dashboard-link VM658:26 A text: |DRep Directory| data-testid: drep-directory-link VM658:26 A text: |Governance Actions| data-testid: governance-actions-link VM658:26 A text: |Proposal Discussion| data-testid: proposal-discussion-link VM658:26 A text: |Guides| data-testid: guides-link VM658:26 A text: |FAQs| data-testid: faqs-link VM658:26 IMG text: || data-testid: copy-button VM658:26 P text: |drep1pzuxy8ukuvffjyyrdp8sxkzp3z8r57z5q0jtgxhwu3a22t9ppel| data-testid: dRep-id-display VM658:26 BUTTON text: |Disconnect| data-testid: disconnect-button VM658:26 A text: |Privacy policy| data-testid: privacy-policy-footer-link VM658:26 A text: |Term of service| data-testid: term-of-service-footer-link VM658:26 BUTTON text: |Help| data-testid: help-footer-button VM658:26 BUTTON text: |Feedback| data-testid: feedback-footer-button VM658:26 DIV text: |Wallet connected| data-testid: alert-success VM658:26 svg text: |undefined| data-testid: SuccessOutlinedIcon VM658:26 svg text: |undefined| data-testid: CloseIcon

vpaunovic commented 3 weeks ago

@MSzalowski This should be assigned to you, right? Because everything in on GovTool

CC: @teske00 @bosko-m @ValMBO @m-i-k-e

NabinKawan commented 3 weeks ago

Hi @vpaunovic, Which version of the PDF npm package has this issue fixed?

kneerose commented 2 weeks ago

Hello @vpaunovic ,

I noticed that the proposal form, review page, and edit proposal forms still have missing test IDs. I mentioned this in issue on above (issue #1070 ), but it appears the changes have not yet been made. Here are the references for the missing test IDs

Screenshot from 2024-06-19 15-20-30 Screenshot from 2024-06-19 16-11-33

kneerose commented 1 week ago

Hello @vpaunovic

I've reviewed your recent updates regarding the missing test IDs. The test IDs I mentioned above are still missing. Additionally, please look into the issue (https://github.com/IntersectMBO/govtool/issues/1099) regarding the create proposal form validation. It currently accepts spaces as input, which needs to be addressed.

Note: Please make sure to add proper test IDs if you introduce any new components in the future. Additionally, please make these adjustments to ensure appropriate test IDs are in place.

bosko-m commented 6 days ago

@kneerose This is included in the latest package prepared yesterday so it should be verifiable soon.

kneerose commented 5 days ago

Hello @bosko-m

I've reviewed your recent updates regarding the missing test IDs in PDF version 0.2.2, but still some issues persist. Below is a detailed list of the required corrections:

1. Title Input

<div class="MuiFormControl-root MuiFormControl-fullWidth MuiTextField-root css-wb57ya-MuiFormControl-root-MuiTextField-root" data-testid="title-input">
    <label class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiInputLabel-sizeMedium MuiInputLabel-outlined MuiFormLabel-colorPrimary MuiFormLabel-filled Mui-required MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiInputLabel-sizeMedium MuiInputLabel-outlined css-1peu7hn-MuiFormLabel-root-MuiInputLabel-root" data-shrink="true" for=":r5pl:" id=":r5pl:-label">Title<span aria-hidden="true" class="MuiFormLabel-asterisk MuiInputLabel-asterisk css-wgai2y-MuiFormLabel-asterisk"> *</span></label>
    <div class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl css-4r00uj-MuiInputBase-root-MuiOutlinedInput-root">
        <input aria-invalid="false" id=":r5pl:" required="" type="text" class="MuiInputBase-input MuiOutlinedInput-input css-1t8l2tu-MuiInputBase-input-MuiOutlinedInput-input" value=" " data-dashlane-rid="29d126c88d925c7b" data-form-type="other">
        <fieldset aria-hidden="true" class="MuiOutlinedInput-notchedOutline css-1d3z3hw-MuiOutlinedInput-notchedOutline">
            <legend class="css-14lo706"><span>Title *</span></legend>
        </fieldset>
    </div>
</div>

The data-testid attribute should be inside the <input> tag instead of the <div> tag.
Similar issue exists for abstract-input, motivation-input, rationale-input, and link-input in both proposal creation and edit proposal sections.
Please ensure to add the testId to the <input> tag for input field

2. Draft saved modal

The test ID is not properly added. The button testid is set as delete-proposal-yes-button, but it is not a delete proposal yes button. Please add a proper test ID.

Note

Ensure that proper test IDs are added if you introduce any new components in the future. Please make these adjustments to ensure appropriate test IDs are in place.

teske00 commented 5 days ago

The package has not yet been imported into govtool, we will report here when it is. We have version 0.2.3

bosko-m commented 25 minutes ago

@teske00 Was this part of the last weeks release?

IntersectMBO / govtool