Data Formatted Incorrectly external data link goes to Rick Astley

[m-i-k-e]

Context & versions

staging . sanchonet Demos wallet

Steps to reproduce

1. Go to DRep directory
2. Click on "Details" button of a Drep entry that is titled "Data Formatted Incorrectly"
3. Click on "See external data"

Actual behavior

You get to see a neato Rick Astley Video\ https://www.youtube.com/watch?v=p7YXXieghto

Expected behavior

You see the external data relative to this DRep

[MSzalowski]

Well... That is not an issue - someone provided this URL while registering as a DRep. I see, that number of such DReps is huge and I investigated this and it seems, that this url is mocked on our automated tests, but - that is the metadata URL that is set and is on chain - which means, that the govtool reflects the true with that link

[MSzalowski]

You can create the transaction of DRep somewhere else (because theoretically - every DRep transaction under GovTool should pass the validation) with any other link, and any link that someone provides as a metadata URL will be visible on that screen.

Should we disable seeing the metadata url button when the metadata fails validation? @m-i-k-e

[m-i-k-e]

Michal, I see what you mean. The reason that the designs provide for this link in this situation is because I assumed that users would want to see what the external data is. However, I now realise that someone could put anything on that link, and bad things could happen. The original link could pass validation - it has to on GovTool, but they could change the content the next minute.

Thanks for pointing this out. It was a mistake to assume that the link might just be some typo. It could be much worse.

@l-br1 Please have a look at this: I think we should remove that link altogether.

[bosko-m]

@MSzalowski will comment on the suggested approach. Wont be included in the next Beta release 12th/13th June.

[l-br1]

@m-i-k-e we don't want to limit what people can submit, we are warning them that those are external links and that is more than enough, also we are warning that they changed the content of the metadata if they do so :) (I'll be one of those people adding rick rolled videos 🤣)