IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://sanchogov.tools/
Apache License 2.0
8 stars 2 forks source link

Auth of data #1421

Open ValMBO opened 1 week ago

ValMBO commented 1 week ago

Context & versions

https://dev-sanchonet.govtool.byron.network/proposal_pillar/proposal_discussion/304

Actual behavior

Authorisation data is requested before doing any action on PDF

Expected behavior

Data authorization should be requested only once, and it should cover submitting/editing proposals, adding comments, and creating polls. Therefore if a user have already submitted a proposal shouldn't be requested to auth the data AGAIN if he wants to add a comment.

teske00 commented 1 week ago

@ValMBO I wanted to ask about this, the situation regarding the editing and deletion of the proposal. That would mean that we have to show these options to everyone at every moment, which I don't know how good it is.

image

teske00 commented 1 week ago

Because it can be a situation, you click edit proposal, the user logs in and nothing happens, but everything disappears because that proposal is not from that user.

teske00 commented 1 week ago

And at the same time it must always be visible. Perhaps we should analyze in more detail what is the best thing to do here. Because I had moments when I wanted to edit a proposal, and in order to log in, I had to do some action, for example to post a comment, and only then can I see the edit for my proposal

ValMBO commented 1 week ago

Okay, but I believe the main issue is that the Edit and Delete options should only be visible to authors of proposals. Is there a way to address this?

teske00 commented 1 week ago

The only way we know someone is the author is if the user is logged in. It's a dependency that I don't know how we can solve here. That's why I had the idea that there should be a button that directly says log me in, rather than triggering everything through actions.

ValMBO commented 1 week ago

Ohh I understand, okey so let me ask Lorenzo.

teske00 commented 9 hours ago

@ValMBO @bosko-m I think this task is no longer valid because we solved these problems by adding an additional screen for wallet verification