IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://sanchogov.tools/
Apache License 2.0
8 stars 2 forks source link

Back Option #1423

Open ValMBO opened 2 weeks ago

ValMBO commented 2 weeks ago

Context & versions

https://dev-sanchonet.govtool.byron.network/proposal_pillar/proposal_discussion/304

Actual behavior

The browser's back button isn't navigating me backward, but selecting "Show all" does restore previous navigation functionality.

Expected behavior

Browser's back button should be in sync with show all

pmbinapps commented 6 days ago

FYI, Spotted it's not working on dev yet, https://jam.dev/c/71ccf0be-4d1a-4e06-94ee-e87bc0d6295b

bosko-m commented 5 days ago

@pmbinapps I've tested with the following and it works: https://dev-sanchonet.govtool.byron.network/proposal_discussion/342 https://dev-sanchonet.govtool.byron.network/proposal_discussion/306

This bug was about browser back functionality when you are on proposal details page, not the page for all proposals. Furthermore, there is no Back to Proposal Discussion link anymore. And I cant see that link on Sancho, nor staging. Strange, can you verify the version you are testing or can you retest?

pmbinapps commented 5 days ago

@bosko-m Yes right, this is about other problem - Browser Back button - and this is working fine on latest dev-sancho. I've meant not working button on Proposals 'Back to Proposal Discussion' - this one is not working

Image

Tracked here: https://github.com/IntersectMBO/govtool/issues/1462

teske00 commented 5 days ago

This is because this is not a new page at the browser level, but the same page with a different view at the application level cc @vpaunovic