[BUG] Proposal Draft is Publicly Accessible

[kneerose]

Context & versions

• When creating a proposal draft, there's a share button on the unfinished draft card. and also the draft becomes publicly visible. Other users can view, and comment on it, and even I can submit the draft for governance action.

Steps to reproduce

• Save the proposal as a draft.
• Observe the draft card.
• Copy the draft URL and paste it into an incognito browser.

Actual behaviour

Questions

• What is the purpose of creating a draft if it is publicly accessible?

[vpaunovic]

We will remove the share icon from the proposal card and handle that with public access to proposal details for draft ones.

CC: @teske00

[vpaunovic]

This is resolved in PDF-UI v.0.2.4. I think that version is on dev sanchonet also.

CC: @teske00 @bosko-m

[bosko-m]

@vpaunovic If I understood correctly, with this fix the following will be true:

1. No share icon on drafted proposals
2. No public access on drafted proposals

Is that correct?

[vpaunovic]

@bosko-m Yes

[vpaunovic]

@bosko-m @kneerose It can be tested on the latest Sancho-dev

[kneerose]

@vpaunovic, I see the share button has been removed, and I could not find the draft on the proposal. It seems the issue is resolved.

CC: @bosko-m