[BUG] Submit Button Non-Functional on Submit Proposal as a Governance Action

IntersectMBO / govtool

🔩 GovTool and utilities monorepo.

https://gov.tools

Apache License 2.0

13 stars 7 forks source link

[BUG] Submit Button Non-Functional on Submit Proposal as a Governance Action #1466

Closed kneerose closed 1 month ago

kneerose commented 3 months ago

Context & versions

When I try to submit my proposal by navigating through the proposal ID or refreshing the proposal details page, the submit button is not functional, preventing me from submitting the proposal as a governance action.

Steps to reproduce

Create a proposal.
Refresh the proposal details page Or navigate through the page using URL
Attempt to submit the proposal as a governance action.

https://www.loom.com/share/d3b5b96a518641da9ed4256703ab1651?sid=05ecb344-45cd-4ed8-aaf1-b2dbd67bb8c6

Actual behaviour

The submit button is clickable but does not trigger any action. An error is displayed in the console.

kneerose commented 3 months ago

Above issue is reproduced on test environment at first
It was just tested on Sanchogov.tools and also the issue is reproduce there

https://www.loom.com/share/8e3c6ccef9734acb9713e1cbae0c34eb?sid=2aba866b-6e8a-4fb7-85c6-4557d40e8ad8 cc: @bosko-m

bosko-m commented 3 months ago

I tested it with the following:

Chrome Browser, SanchoNet, Eternl wallet
Used proposal I created yesterday
Clicked submit it as a governance action
Tried incorrect url like in the loom video (I assumed the problem there) - expected behavior (Image attached)
Tried correct URL - expected behavior (Image attached)

Given what is observed I dont see it as P0 anymore, might be P1 but it needs to be investigated further. @kneerose @spannercode

kneerose commented 3 months ago

@bosko-m, have you tried refreshing the proposal details page and submitting it as a governance action?

This video will clarify it for you better

https://www.loom.com/share/425c1f96877240ee9998d713433c6d5d?sid=dafd1ad7-9522-41b0-9c3a-6e50c91b6285

spannercode commented 3 months ago

To reproduce the issue, refreshing the proposal page is important which causes the re-verification of the identity. Without refreshing the page, the issue does not occur on the normal flow.

vpaunovic commented 3 months ago

@kneerose @spannercode We worked on that signData modal now on refresh, because it was doing that on the deployed version but locally it does not happen. So we worked on that thing, and hopefully, that will sort out that on the deployed version too. We will inform you when it is available in new version.

CC: @teske00

vpaunovic commented 3 months ago

@kneerose @spannercode It is available in v.0.2.5.. It will be available on dev-sancho as soon as guys import it and redeploy it.

CC: @bosko-m @teske00

pmbinapps commented 3 months ago

@bosko-m this is currently not working on test-sancho. Works fine on dev-sancho and beta.

On test following error msg is shown when Submit is clicked:

To reproduce: Make GA with following data:

Link #1: https://test.com

Use json: https://raw.githubusercontent.com/pmbinapps/vva/main/tmp/data.jsonld

vpaunovic commented 2 months ago

@bosko-m @kneerose It can be tested on the latest Sancho-dev and closed everything is okay.

CC: @teske00

kneerose commented 2 months ago

I have tested this on both the test and dev environments on Sanchonet, and it does not reproduce anymore.

CC: @bosko-m

bosko-m commented 2 months ago

Thanks @kneerose . @vpaunovic Will be closed once its released to Sancho (Beta).

vpaunovic commented 2 months ago

@bosko-m Isn't it already on beta?

kneerose commented 1 month ago

I have tested this on both the test and dev environments on Sanchonet, and it no longer reproduces.

This issue can be closed now.
CC: @bosko-m

bosko-m commented 1 month ago

Closing as per the comment above.