Closed kneerose closed 2 weeks ago
@kneerose It is deployed on dev, it can be tested
I have reviewed your changes, but it seems you missed adding test IDs for the new components. Please ensure that you include proper test IDs for any new components in the future.
@kneerose It can be tested on dev with new version of pdf now.
CC: @bosko-m
@vpaunovic
The "Required" message is always visible. Is it intended to be always visible? Currently, the test ID used for "Required" is the same as that for "Invalid URL" and "URL must be less than 128 bytes." This will conflict with our test. If the "Required" message is intended always to be shown, please use a different test ID for each message.
@kneerose It is required. It is helper text, not an error. The error is red color and red border around input.. so.. i will put different testid string in case if it is error or just helper text.And we will put it in new pdf package version! š
cc: @teske00
@kneerose It is fixed and it will be available in new pdf package version and when it is deployed on dev. It will have required-url-input-text
data-testid when there is no error and just Required text as helperText.
CC: @teske00
@vpaunovic I see the changes on the dev environment but not yet on the test environment . The ticket will be closed once the changes are available in the test environment. CC: @bosko-m
Please dont close it after it passes the testing on test environment @kneerose . Intersect should give in this case final sign off after testing it on staging.
I've reviewed the changes on the test environment.
This issue can be closed now.
CC: @bosko-m
Closing as per the comment above.
Context & versions
Steps to reproduce
Actual behaviour
Expected behaviour
Report Reference