IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://gov.tools
Apache License 2.0
14 stars 9 forks source link

The CI/CD workflows has to be cleaned up and fixed #168

Closed MSzalowski closed 1 month ago

MSzalowski commented 9 months ago

Investigate why storybook and lighthouse actions fails on every workflow execution and fix them.

placek commented 9 months ago

As I am no specalist in Storybook nor Lighthouse I will pass this issue to someone competent to fix the workflows.

For now, in order to keep the development process clean and improve developers experience by not providing false negative feedback to their work, I am disabling those two workflows manually.

It is expected that those workflows (storybook and lighthouse) will be enabled again once the issue is addressed.

spannercode commented 1 month ago

@bosko-m I think this issue can be closed:

Here are the GH actions link for storybook and lighthouse tests: https://github.com/IntersectMBO/govtool/actions/workflows/test_storybook.yml https://github.com/IntersectMBO/govtool/actions/workflows/lighthouse.yml

Regarding Lighthouse, while the github action is passing, it does not mean that there are no issues.

The results are published here: https://lighthouse-govtool.cardanoapi.io/app/projects/govtool/dashboard

And there are related issues:

bosko-m commented 1 month ago

Closing as per the comment above.