IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://gov.tools
Apache License 2.0
14 stars 9 forks source link

🐛 Drep card on dashboard should show DRep name, and not label #1958

Open m-i-k-e opened 2 months ago

m-i-k-e commented 2 months ago

Area

Delegation Pillar

Domain

gov.tools

Which wallet were you using?

Demos 1.8.2

Context

Dashboard view

Steps to reproduce

  1. Be a drep
  2. Look at Dashboard

Actual behavior

You see 'DRep ID' above the DRep ID

Expected behavior

You should see the DRep name

m-i-k-e commented 2 months ago

This needs designing, as it's not correct in Figma. I will ask Kasia to look into it.

Ryun1 commented 1 month ago

I think this is already done

m-i-k-e commented 1 month ago

@Ryun1 This hasn't been done on preview as of today (thursday the 12 of Sept)

bosko-m commented 2 weeks ago

@m-i-k-e Can you please provide screenshot of what the expected would be?

In the dashboard DRep box, there is a DRep id label and then DRep id itself below. There is also a copy button to copy the id into the clipboard which has a meaning.

Image

When you go to the DRep details page, thats where you see the DRep name above DRep id.

Image

CC @Ryun1

m-i-k-e commented 3 days ago

Currently, the name has been removed:

image
m-i-k-e commented 3 days ago

Archived Figma branch 1958

m-i-k-e commented 3 days ago

This is the correct solution in Figma: https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=7838-145859&t=xaC11CQKDDby1Wbv-1

image
bosko-m commented 3 days ago

@m-i-k-e I think this screen needs to be slightly adjusted as the button shouldnt be Learn More but View your DRep details.