IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://gov.tools
Apache License 2.0
14 stars 9 forks source link

🐛 Governance Action can be submitted multiple times consecutively without leaving the page #2264

Open bosko-m opened 4 weeks ago

bosko-m commented 4 weeks ago

Area

Proposal Pillar

Domain

preview.gov.tools

Which wallet were you using?

Lace

Context

Was exploring end 2 end user experience of a proposal evolving into the governance action.

Reference loom video - https://www.loom.com/share/b57d9f1ad28345e0b16415ca05549afa?sid=61f53e95-b96e-4cd3-bf7a-86d399d9dabd

Steps to reproduce

  1. Go to the specific proposal and submit it as governance action
  2. Fill in the steps all the way to the last screen where you could submit it
  3. Click submit
  4. On the success message modal click x to close it
  5. Click submit again

Actual behavior

  1. You are able to submit it

Expected behavior

  1. You shouldnt be able to submit it as upon success message you should be taken out of that screen to the list of governance actions or list of proposals where you can see your proposal you just submitted as governance action.
kneerose commented 3 weeks ago

Screenshot from 2024-10-29 11-33-01

Displaying this popup would be a better option when the user tries to re-submit a proposal, until the transaction is completed

m-i-k-e commented 3 weeks ago

@MSzalowski That will not fix the bug, as the user can dismiss this and re-submit. In UX you cannot depend on users to read instructions and follow them. The interface itself needs to be foolproof.

How do multiple GAs work? Do copies go on chain, or is there a different bug?