search

IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://gov.tools
Apache License 2.0
14 stars 9 forks source link

🐛 DRep error conditions in docs hes duplicate subtitles #2308

Open bosko-m opened 2 weeks ago

bosko-m commented 2 weeks ago

Area

Other

Domain

gov.tools

Which wallet were you using?

No response

Context

I was trying to check the linking within GovTool so I clicked learn more on the GA with incorrect metadata.

Steps to reproduce

  1. Go to this GA - https://gov.tools/connected/governance_actions/51f495aa23f4b3b3aa90afde4a0e67823bb7ac4ac65f5ffbb138373b863f2f74#0
  2. Click on Learn more (brings you to https://docs.gov.tools/about/what-is-cardano-govtool/govtool-functions/dreps/drep-error-conditions)

Actual behavior

  1. There are two subtitles with the same name - Data Not Verifiable

Expected behavior

  1. There should only one subtitle with the Data Not Verifiable name. In other words those two should be distinctive in some way. If there is a reason to have the same message in both cases, then it should still be one subtitle but with two bullet points or paragraphs for different cases.
m-i-k-e commented 2 hours ago

@bosko-m I see what you mean: We are using the same title for two different errors.

The simplest solution to this would be to combine the two errors into one "Data not verifiable". We would essentially remove the fourth one, as while this is a different case, it's a real edge case and if the data has changed, it's probably a moot point whether it's in the correct format.