IntersectMBO / govtool

🔩 GovTool and utilities monorepo.
https://preview.gov.tools
Apache License 2.0
10 stars 7 forks source link

[USERSNAP] units and alignment #881

Closed kickloop closed 4 weeks ago

kickloop commented 4 months ago

Taken at: https://sanchogov.tools/connected/governance_actions/10749d25c892a6ec20fc9365425dc204c6a2699ce1586bdb0e6802eccd6263f2#0 Fields:

Browser: Chrome 124 (Linux) Screen size: 1920x1080 Open #38 in Usersnap

Powered by Usersnap.

m-i-k-e commented 4 months ago

If I understand what the user is saying, they want to see better aligned voting numbers in GA action detail pages.

Here is the (new) figma design for showing votes. There is no votes past the decimal point, but there should be commas to separate the thousands.

image
m-i-k-e commented 4 months ago

I will add this to the design queue.

m-i-k-e commented 4 months ago

@GypsyBinar Please make a version of Vote counting where there are thousands separators.

m-i-k-e commented 3 months ago

There is a Figma branch for this file. @GypsyBinar Did you work on it? if so, please can you add a link here so I can check it?

kgrzonka commented 3 months ago

@m-i-k-e https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/branch/3j2eeOxRE58qwZPeZDy3O7/Voltaire---GOV-TOOL?m=auto&node-id=8462%3A51213&t=VbSEye8CK4eCkCqh-1

kgrzonka commented 3 months ago

@m-i-k-e and in this case we don't need branching. I change the copy in components in Master ok?

m-i-k-e commented 3 months ago

@kgrzonka Yes, please do exactly that. And then say what you've done here in github.

Thanks!

kgrzonka commented 3 months ago

@m-i-k-e https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=9420%3A158655&t=KJhF4p4O8ZBQ60yz-1

Done :)

m-i-k-e commented 3 months ago

Thanks, @kgrzonka This looks good.

m-i-k-e commented 3 months ago

@MSzalowski This is ready to implement

m-i-k-e commented 1 month ago

@MSzalowski Did this get implemented?