IntersectMBO / lsm-tree

A Haskell library for on-disk tables based on LSM-trees
Apache License 2.0
24 stars 7 forks source link

Add incremental functionality for the ordinary index #299

Closed jeltsch closed 2 weeks ago

jeltsch commented 1 month ago

This adds support for incremental construction and serialization of ordinary indexes.

Note that the branch of this pull request is currently stacked onto the branch of #296, as it depends on it. Once #296 is merged, I shall rebase the branch of the present pull request onto the then current main.

jorisdral commented 1 month ago

Note that the branch of this pull request is currently stacked onto the branch of https://github.com/IntersectMBO/lsm-tree/pull/296, as it depends on it. Once https://github.com/IntersectMBO/lsm-tree/pull/296 is merged, I shall rebase the branch of the present pull request onto the then current main.

You can set #296 as the target branch for this PR, and then the PR only shows the changes with respect to #296. When #296 is merged, the target branch automatically changes to main and you won't have to rebase

jeltsch commented 3 weeks ago

You can set #296 as the target branch for this PR, and then the PR only shows the changes with respect to #296.

Done. 🙂

jeltsch commented 2 weeks ago

LGTM. Let's merge after you've squashed the commits, and after you've resolved my last comment.

Squashed into 1b3158bebfa4122de1491ef115d50b0d6ccce5ea. Ready to be merged.