ContractModel: add the ability to perform observations of the blockchain in `DL` properties

IntersectMBO / plutus-apps

The Plutus application platform

Apache License 2.0

305 stars 213 forks source link

ContractModel: add the ability to perform observations of the blockchain in `DL` properties #1055

Closed MaximilianAlgehed closed 1 year ago

MaximilianAlgehed commented 1 year ago

This fixes the need for custom endpoints as used e.g. in the Governance example.

Pre-submit checklist:

Branch
- [x] Tests are provided (if possible)
- [x] Commit sequence broadly makes sense
- [x] Key commits have useful messages
- [x] Formatting, PNG optimization, etc. are updated
- [x] Important changes are reflected in changelog.d of the affected packages
PR
- [x] Self-reviewed the diff
- [x] Useful pull request description
- [x] Reference the ADR in the PR and reference the PR in the ADR (if revelant)
- [x] Reviewer requested

MaximilianAlgehed commented 1 year ago

@sjoerdvisscher do you want to have a look at this?

MaximilianAlgehed commented 1 year ago

One issue we have here is that we are a little bit blocked on this PR: https://github.com/input-output-hk/quickcheck-contractmodel/pull/13 as it would be nice if we could depend on the version of quickcheck-contractmodel in CHaP rather than on a source repository stanza. However, I wanted to get this PR up here so that the whole chain of things is at least visible.

sjoerdvisscher commented 1 year ago

One issue we have here is that we are a little bit blocked on this PR: input-output-hk/quickcheck-contractmodel#13 as it would be nice if we could depend on the version of quickcheck-contractmodel in CHaP rather than on a source repository stanza. However, I wanted to get this PR up here so that the whole chain of things is at least visible.

It seems that the PR to add it to CHaP has a possibly complicated build error. I'm also fine with keeping it like this for now, and to start depending on the CHaP version later.

MaximilianAlgehed commented 1 year ago

@sjoerdvisscher how close to merging this do you think we are? Do you understand what's up with the build?

MaximilianAlgehed commented 1 year ago

@sjoerdvisscher I think this should be ready to merge. Although I don't know what's going on with CI timing out?

sjoerdvisscher commented 1 year ago

No problem, it's just the darwin tests, the linux tests are fine. This happens from time to time.

@koslambrou Could you please merge this?