IntersectMBO / plutus

The Plutus language implementation and tools
Apache License 2.0
1.57k stars 476 forks source link

`liftCode` using `plcVersion110` in release `1.5.0.0` #5491

Closed sourabhxyz closed 1 year ago

sourabhxyz commented 1 year ago

Describe the feature you'd like

Is this desired? Docs mention using liftCode here but then would such a validator even run? If this is an issue, is there a simple workaround for it for someone who is constrained to use version 1.5.0.0 as a dependency.

Thanks for your time.

Describe alternatives you've considered

No response

sourabhxyz commented 1 year ago

Also, seeing runCompiler function, it appears that default compilation is also using version 1.1.0.

Am I missing something or is this an issue? Also, I am aware that these issues are resolved for in release 1.6 with support of target-version option but cardano node 8.1.2 (if I build it) uses release 1.5 as a dependency.

effectfully commented 1 year ago

Apologies for the silence here, we're trying to set up a proper process for reacting to issues, but it clearly didn't work for this one.

is there a simple workaround for it for someone who is constrained to use version 1.5.0.0 as a dependency

I've asked around and there doesn't seem to be a workaround if you're hard-constrained to 1.5.0.0 exactly, since we can't mutate a release. However if you can get 1.5.0.1, then you'll have access to target-version, since it was backported to that version. I don't know if cardano-node-8.1.2 picks up 1.5.0.1 these days, but I hope it does.

There doesn't appear to be anything else that we can do in the context of this issue, hence I'm closing it. If you disagree, please do feel free to reopen the issue. And once again, apologies for it taking so long for us to respond, we are trying to improve on that front.

sourabhxyz commented 1 year ago

Thanks a lot @effectfully for your feedback. We got over it by hacking constraints to use 1.6.0.0 https://github.com/geniusyield/atlas/blob/58a30a5034cc92ac2d3d42594f09b9ac2849c0b4/cabal.project#L37-L53.

effectfully commented 1 year ago

Great, I'm glad you'd found a workaround.