search

IntersectMBO / plutus

The Plutus language implementation and tools
Apache License 2.0
1.55k stars 466 forks source link

Spelling mistake? #6243

Closed perturbing closed 1 week ago

perturbing commented 1 week ago

https://github.com/IntersectMBO/plutus/blob/bc8c3a765769d2c0cd41c43278f5954cfdfd9b15/plutus-ledger-api/src/PlutusLedgerApi/V3/Contexts.hs#L220

did you mean

-- | Similar to TxOutRef, but for GovActions
data GovernanceActionId = GovernanceActionId
  { getTxId        :: V3.TxId
  , getGovActionIx :: Haskell.Integer
  }
  deriving stock (Generic, Haskell.Show, Haskell.Eq, Haskell.Ord)
effectfully commented 1 week ago

No, gaid is a (weird) abbreviation of GovernanceActionId, it's pretty common in the Haskell world to prefix fields with an abbreviation of the type name due to the lack of type-based name resolution (workarounds exist, but we don't use them).

So I think this is as intended and I'm gonna close the issue as such. But thank you for double-checking!