Open kstekovi opened 1 year ago
Hi @kstekovi - and thanks for filing this issue.
Do I understand correctly that your issue is to avoid using the oc
binary in first place?
In such case, yes, we would be on the same page since the less it's used, the better.
That being said, though, I think you're relating to WildflyOpenShiftApplication
, correct?
If that is true, those methods' implementation is called by the OpenShiftProvisioner
preDeploy()
and popstUndeploy
.
This is by design, i.e. it means that any OpenShiftProvisioner
concrete implementation could follow this behavior and for this very reason the feature you're proposing should:
HasRoles
) which defines the two methods (e.g.: getRoles()
and getRoleBindings()
)WildflyOpenShiftApplication
implement them returning Collections.emptyList()
as it's currently doing for getSecrets()
.WDYT?
Do I understand correctly that your issue is to avoid using the
oc
binary in first place?
Yes, This is exactly the reason why i create this.
That being said, though, I think you're relating to WildflyOpenShiftApplication, correct?
Yes. Description of the issue updated.
Thank you for suggestion.
Is your feature request related to a problem? The Intersmash doesn't support creating Role and RoleBinding.
Describe the solution you'd like The Intersmash support resources for Secrets. The solution for Role and RoleBinging could be similar to Secrets.
getRoles()
andgetRoleBindings()
)OpenShiftProvisioner
Describe alternatives you've considered Now you can execute
oc
commands to create required resource.Additional context This could help with test implementation for
autodiscovery
feature which require permission to list routes from OpenShift. Theautodiscovery
is a feature used by OIDC and SAML authentication. The deployment application in Wildfly can register itself in Keycloak authentication server automatically. For this automatic registration require know what is its host name. Theautodicovery
is feature can load the host name from OpenShift but it require the permission to list routes. So you don't need to configure the host name of your application in your HelmChart (OIDC_HOSTNAME_HTTP/S
variable for OIDC andSSO_HOSTNAME_HTTP/S
for SAML)