Remove unused OS based differentiation from the CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method

Intersmash / intersmash

Intersmash - Cloud-native testing with Java!

Apache License 2.0

5 stars 13 forks source link

Remove unused OS based differentiation from the CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method #198

Closed fabiobrz closed 2 months ago

fabiobrz commented 2 months ago

The CommandLineBasedKeystoreGenerator::getSplitCommandNameBasedOnOeratingSystem method is taking the mac value for the os.name system property into account, which doesn't make sense, since Intersmash only supports Linux execution.

The method should be removed altogether.

See https://github.com/Intersmash/intersmash/pull/180#discussion_r1743137841

Environment: core module
Steps to reproduce: N/A

TheMarvelFan commented 2 months ago

Hi, Is anyone working on this issue?

fabiobrz commented 2 months ago

Hi,

Is anyone working on this issue?

Hi @TheMarvelFan, and thanks for your question. Nobody is working on this issue, would you like to take it? We love for the community to contribute, so you'd have a green light here! 🙂

TheMarvelFan commented 2 months ago

Yes I'd love to work on it.

fabiobrz commented 2 months ago

Yes I'd love to work on it.

Thanks! I've ssigned the issue to you, then :slightly_smiling_face:

TheMarvelFan commented 2 months ago

Hi @fabiobrz,

I've made the necessary changes and opened a PR. Please review it and let me know if any changes are rerquired.

Thanks!

fabiobrz commented 2 months ago

Closing as done via #203