Removed the method CommandLineBasedKeystoreGenerator::getSplitCommand…

TheMarvelFan commented 1 month ago

…NameBasedOnOeratingSystem

Fixes issue #198

Removed the above mentioned method. It was returning "gcsplit" when the "os.name" property was "mac", and "csplit" otherwise.

Since Intersmash supports only Linux execution, I hardcoded the value "csplit" where the method call was returning this value, as it is not supposed to change.

Description

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] I have implemented unit tests to cover my changes
[x] I tested my code in OpenShift

fabiobrz commented 1 month ago

/test

fabiobrz commented 1 month ago

Intersmash PR CI check results

Hi @TheMarvelFan, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see https://github.com/Intersmash/intersmash/pull/203#issuecomment-2374264757.

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#136> FAILED:

Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#64> reported failures.
Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap#74> reported failures.
Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80> reported failures.

Please verify your changes locally or reach out to maintainers in order to investigate the issues.

TheMarvelFan commented 1 month ago

Hi @fabiobrz, Can you please elaborate about the failing tests? I have followed all the conventions listed in CONTRIBUTING.md, and I don't understand what the issue is here.

Thanks!

fabiobrz commented 1 month ago

Intersmash PR CI check results

Hi @TheMarvelFan, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #203 (comment).

CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#136> FAILED:
* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#64_> reported failures.

<eap-8.x-intersmash-integration-tests-community#64> reported 1 failure, i.e.:

cz.xtf.core.waiting.WaiterException: 
Following events match condition: <at least one exists>
    2024-09-25T14:49:37Z    Build/wildfly-test-app-1    Build appsint-asfl/wildfly-test-app-1 failed
Filter:  obj names: [wildfly-test-app.*]
     messages: [Failed to pull image.*, Build.*failed, Error syncing pod, skipping: failed to.*, FailedMount MountVolume.SetUp.*, Error creating: pods.*is forbidden:.*, .*failed to fit in any node.*, Failed to attach volume.*]
     after: 2024-09-25T14:48:03Z

    at org.jboss.intersmash.testsuite.provision.openshift.WildflyImageProvisionerTestCase.deploy(WildflyImageProvisionerTestCase.java:57)
...

which is a new one, but unrelated to the changes in this PR. We're investigating it as it happens with the main branch too. :yellow_circle:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap#74_> reported failures.

<eap-8.x-intersmash-integration-tests-products-jboss-eap#74> reported 1 failure, i.e.:

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <503>.

    at org.jboss.intersmash.testsuite.provision.auto.AutoProvisioningTests.testAppIsLive(AutoProvisioningTests.java:53)

which is an intermittent one, reported as fixed by the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap#75> :white_check_mark:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80_> reported failures.

<eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80> reported 3 failures, i.e.:

org.jboss.intersmash.testsuite.provision.openshift.ProvisionerCleanupTestCase.testProvisioningWorkflowCleanup

cz.xtf.core.http.HttpsException: javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
at ...

org.jboss.intersmash.testsuite.provision.openshift.WildflyTargetServerTestCase.deploy

cz.xtf.core.waiting.WaiterException: 
Following events match condition: <at least one exists>
2024-09-25T15:48:09Z    Pod/wildfly-test-app-1-z7kxz    Failed to pull image "image-registry.openshift-image-registry.svc:5000/appsint-main-qmhx/wildfly-test-app@sha256:380949daddd4b090a19ab332d20f418dc966919bb67ff6d0b851390b8a6a8311": unable to retrieve auth token: invalid username/password: authentication required

org.jboss.intersmash.testsuite.provision.openshift.WildflyBootableJarTestCase.deploy

cz.xtf.core.waiting.WaiterException: 
Following events match condition: <at least one exists>
2024-09-25T15:48:50Z    Build/bootable-jar-1    Build appsint-main-qmhx/bootable-jar-1 failed
Filter:  obj names: [bootable-jar.*]
 messages: [Failed to pull image.*, Build.*failed, Error syncing pod, skipping: failed to.*, FailedMount MountVolume.SetUp.*, Error creating: pods.*is forbidden:.*, .*failed to fit in any node.*, Failed to attach volume.*]

All of them are intermittent issue, reported as fixed by the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#81> :white_check_mark:

Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

fabiobrz commented 1 month ago

Can you please elaborate about the failing tests?

Sure @TheMarvelFan - what you see here is the result of integration tests which have been triggered by a comment of mine.

The report is posted as a comment made by me, although it is an automated process.

This is a temporary solution which we're testing and improving right now. In theory we aim at using a service account and proper checks. See more details here.

I have followed all the conventions listed in CONTRIBUTING.md, and I don't understand what the issue is here.

Hopefully it's more clear now, but definitely thank you for your feedback, which helps us improve the CI processes and the related documentation.

As you can see above, I've then reviewed the failures in the jobs which are mentioned in the report, and have deemed the changes to pass the integration tests :slightly_smiling_face:

Intersmash / intersmash