search

Intervention / image

PHP Image Processing
https://image.intervention.io
MIT License
13.84k stars 1.5k forks source link

feature: implemented text outline #1296

Closed amowogbaje closed 6 months ago

amowogbaje commented 7 months ago

I noticed the stroke functionality on text watermark was not functional so I implemented that kindly merge please so i can see it in the next installment

olivervogel commented 7 months ago

Thank you for your updates. Please edit the following two things because otherwise I cannot merge it.

  1. The font system has been heavily rewritten by me in https://github.com/Intervention/image/pull/1292. I suggest that you build your PR on the state of the not-yet-integrated state of #1292 , which will be integrated in the next minor release on February 17, 2024. I would suggest to merge feature/text-wrapping into this (your) feature branch and fix possible conflicts. After that you can push to GitHub again.

  2. Intervention image is a library that provides a unified API for GD and Imagick. The goal is that every command will produce the same result when you replace the driver. I realize that this is not always 100% possible, as GD and Imagick work differently, but it should be a benchmark. However, the new feature currently only works with GD. I would ask you to add it for Imagick as well.

Text outline with Imagick is definitely possible.

$draw = new ImagickDraw();
$draw->setStrokeColor('#000');
$draw->setStrokeWidth(4);
$draw->setStrokeAntialias(true);

https://www.php.net/manual/en/imagickdraw.setstrokecolor.php https://www.php.net/manual/en/imagickdraw.setstrokewidth.php https://www.php.net/manual/en/imagickdraw.setstrokeantialias.php

And it's even easier than with GD. 😄

amowogbaje commented 7 months ago

merged feature/text-wrapping into add-outline-to-text branch

amowogbaje commented 7 months ago

I am lost with the failed checks

amowogbaje commented 6 months ago

Please Sir I'd love to improve on my open source contribution what are the things you feel I could improve and what other open source task can I take on

Gideon Amowogbaje [image: https://]about.me/amowogbaje https://about.me/amowogbaje?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=edit_panel&utm_content=plaintext

On Mon, Feb 12, 2024 at 3:11 PM Oliver Vogel @.***> wrote:

Closed #1296 https://github.com/Intervention/image/pull/1296.

— Reply to this email directly, view it on GitHub https://github.com/Intervention/image/pull/1296#event-11775096339, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACC5L4VLF3FILQZMO5D552LYTIPKRAVCNFSM6AAAAABC3UN6K6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRG43TKMBZGYZTGOI . You are receiving this because you were assigned.Message ID: @.***>

olivervogel commented 6 months ago

I just closed this because you opened another MR with the same content. Lets work on #1300