search

Intervention / image

PHP Image Processing
https://image.intervention.io
MIT License
13.88k stars 1.5k forks source link

Fix bug with unwanted color in DrawLineModifer #1348

Closed olivervogel closed 5 months ago

olivervogel commented 5 months ago

See #1347

olivervogel commented 5 months ago

The bug is fixed and the tests are successful in the GitHub workflow, but for unknown reasons there is an error in the Docker test environment.

docker-compose run --build --rm tests

[...]

There was 1 failure:

1) Intervention\Image\Tests\Unit\Drivers\Gd\Modifiers\DrawLineModifierTest::testApplyTransparent
Failed asserting that color rgba(255, 255, 255, 255) equals rgba(255, 129, 66, 255)
Failed asserting that an array contains 255.

/project/tests/BaseTestCase.php:79
/project/tests/Unit/Drivers/Gd/Modifiers/DrawLineModifierTest.php:36

Could be related to GD Version bundled (2.1.0 compatible), which is approx. 8 years old and not supported anymore. The error does not occur with the current GD version 2.3.3.

This must be investigated before the fix can be merged.