timmeijers
commented
1 year ago Hi Oliver,
Ofcourse!
In the netherlands we use only one format of postal codes which starts with 4 digits and ends with 2 capital letters.
1234AB In some odd situations we do allow there to be a space between. So thats why i added the \s? To make that optional, like the following 1234 AB
But since i didnt want to force the case sensitive part for people already using this i kept the a-z and the /i
If you want to make it more strict you can do A-Z and remove the case insensitive marker.
If you have any questions, feel free to ask.
Kind regards, Tim Meijers
From: Oliver Vogel @.> Sent: Tuesday, June 13, 2023 4:18:54 PM To: Intervention/validation @.> Cc: timmeijers @.>; Author @.> Subject: Re: [Intervention/validation] Fixes and changes for dutch language and postal code (PR #69)
Thanks for your contribution. Unfortunately, the MR makes the tests fail for some NL postal codes.
- 1234 should be valid but returns invalid now.
- 1234AA should be invalid but is now valid.
Can you tell me more about valid postal codes in the Netherlands?
— Reply to this email directly, view it on GitHubhttps://github.com/Intervention/validation/pull/69#issuecomment-1589411857, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASZMHEERZMJ7WFY23WI6NDXLBZE5ANCNFSM6AAAAAAZEQUIRE. You are receiving this because you authored the thread.Message ID: @.***>
olivervogel
Thanks for your contribution. Unfortunately, the MR makes the tests fail for some NL postal codes.
1234should be valid but returns invalid now.1234AAshould be invalid but is now valid.Can you tell me more about valid postal codes in the Netherlands?