search

Intevation / intelmq-certbund-contact

IntelMQ expert bots to lookup contact information in a database (part of the intelmq-cb-mailgen solution).
GNU Affero General Public License v3.0
3 stars 2 forks source link

download script: errors and requirements #1

Closed ghost closed 5 years ago

ghost commented 5 years ago

ripe_download: Document curl requirement ripe_download: Fail early setup/requirements: add psycopg2

bernhardreiter commented 5 years ago

@wagner-certat thanks for the pull request.

One question: is psycopy2-binary good to specify as requirement? I'm asking because https://pypi.org/project/psycopg2-binary/ says The binary package is a practical choice for development and testing but in production it is advised to use the package built from sources.

And I wonder if this requirement is also satisfied, if a good installation from a package or from sources has been made. Do you know if this is the case?

ghost commented 5 years ago

If I remember correctly, they actually recommended the binary package in the past. Anyway, I changed that.

And I wonder if this requirement is also satisfied, if a good installation from a package or from sources has been made. Do you know if this is the case?

In our installations of intelmq we use the packages provided by the package management. For some other projects with virtualenvs we use the psycopg2 packages without problems (also with changing psql versions)

bernhardreiter commented 5 years ago

Thanks!