search

Intevation / intelmq-certbund-contact

IntelMQ expert bots to lookup contact information in a database (part of the intelmq-cb-mailgen solution).
GNU Affero General Public License v3.0
3 stars 2 forks source link

certbund-contact: improve ripe postgresql importer #2

Open bernhardreiter opened 8 years ago

bernhardreiter commented 8 years ago

I'm looking at commit 86a8aef4e771915d6b879ea9d1ccf48100d5f264 and creating this issue to document a number of questions and possible improvements I have.

Specific about https://github.com/Intevation/intelmq/blob/86a8aef4e771915d6b879ea9d1ccf48100d5f264/intelmq/bots/experts/certbund_contact/README.md

Should be --encrypted used for createuser? in

Adding contacts will be possible as intelmq user as well, so we should probably change this.

About https://github.com/Intevation/intelmq/blob/86a8aef4e771915d6b879ea9d1ccf48100d5f264/intelmq/bots/experts/certbund_contact/README-ripe-import.md it is stressed that you have to be the system user "postgres", why? Should'nt it work as the system user "intelmq" as well, if "peer" authentication is enabled in postgresql (standard default). Or where is the issue to add password usage?

bernhardreiter commented 5 years ago

Should be --encrypted used for createuser?

No, because the default behaviour is used, which should be configured secure enough. Here the link to the PostgreSQL 11 documentation: https://www.postgresql.org/docs/11/runtime-config-connection.html#GUC-PASSWORD-ENCRYPTION and https://www.postgresql.org/docs/current/app-createuser.html which shows that the option is deprecated.