Intevation / intelmq-fody-backend

A backend to serve intelmq-cb-mailgen data for the webapp fody.
2 stars 2 forks source link

Events table not configurable #16

Closed ghost closed 6 years ago

ghost commented 6 years ago

https://github.com/Intevation/intelmq-fody-backend/blob/b4992ea/events_api/events_api/serve.py#L399

Could/should be a configurable

bernhardreiter commented 6 years ago

Hi @wagner-certat, out of curiosity: What is the use case for configurating this? Wouldn't it be better if most installations would agree on using "events" here?

ghost commented 6 years ago

Wouldn't it be better if most installations would agree on using "events" here?

Sure, but is the name of the table really a hard dependency?

In our case I want fody to operate on a view. Otherwise I need to rename the view, then the events table is no longer called events (but you suggest the opposite) :)

bernhardreiter commented 6 years ago

No, its not, thanks for mentioning the view use-case, my imagination was not at its highest level in this moment. ;)