search

Intevation / intelmq-fody

Web interface to IntelMQ
9 stars 3 forks source link

Deal with inhibitions added by add_inhibition.py #31

Closed bernhardreiter closed 7 years ago

bernhardreiter commented 7 years ago

intelmq-cb-mailgen's contactdb in the current version uses inhibitions added by add_inhibition.py. To make fody available, we have to consider that some entries in the tables inhibition and network exist. (Entries in organisation_to_network are not created, which probably is a defect.)

As a new configuration scheme is coming up, we only need to be able to at least display the data and show when it would be deleted with an autonomous_system.

bernhardreiter commented 7 years ago

For testing purposes I'm creating a test entry like

echo '422;192.168.0.1;spam;openntp;"Test Entry"' >t
bash /usr/lib/python3/dist-packages/intelmq/bots/experts/certbund_contact/add_inhibitions_from_file.sh t
bernhardreiter commented 7 years ago

4a82b290b6210d8baf7c7722bf52231121678e2d now display inhibitions, without support for editing. The contactdb_api mailgen:2d36db2c14a77e15a5563cd7d887bee6b1ba6464 supports this for display and editing. TODO update when removing an asn.

bernhardreiter commented 7 years ago

Here more test cases:

cat >t << EOF
422;192.168.0.1;spam;openntp;"Test Entry"
;192.168.0.2;;openntp;"Test Entry"
49234;192.168.0.2;spam;openntp;"Test Entry"
49234;;spam;;"Test Entry"
49234;;;;"Test Entry"
EOF
bernhardreiter commented 7 years ago

inhibition display and removal is now supported, even with inhibitions that only are attached to the asn. inhibition without link to an asn cannot be displayed right now.