IntrepidPursuits / android-utils

A collection of common Android utility methods
Apache License 2.0
2 stars 0 forks source link

IntrepidRxJavaUtils #3

Open shadow7 opened 8 years ago

shadow7 commented 8 years ago

I'd like to propose opening a PR for adding a new file called IntrepidRxJavaUtils. This class would contain static helper functions for composing common observable actions such as error logging, creating scheduler patterns, and filtering results. The aim of this library is also to show how to correctly implement TestSubscribers so that future projects will have guide lines to follow.

f2rf2r commented 8 years ago

My concern is that this requires our library to add RxJava/RxAndroid as dependencies which makes it a bit bloated. This kinda goes with the general question of how much functionality we want this library to have. Do we want to only include the core methods that almost every app will be using, or do we also want to add on methods that might be useful but won't be used often?

shadow7 commented 8 years ago

@gdaniels @streetsofboston @f2rf2r I think there's a case that each file, including the IntrepidRxJavaUtils proposed, should be in their own library. This will make them extremely modular and light weight. It will allow projects to exclude Rx as a dependency, as well as exclude unwanted utility methods from projects with a high method count trying to avoid Multi Dex.

grmartin commented 7 years ago

@shadow7 @streetsofboston @gdaniels @f2rf2r Commons does a set of libraries where you can pick a monolithic version or any one of a handful of small libraries and their dependencies. I like that mode personally.