Feedback CB: Disagreement over "Line Character Limits"

[cprime]

I do not agree with “Line Character Limits”. If this is the convention I will follow it, but I think it adds unnecessary work for a developer, particularly when dealing with long strings. Could you at least add an explanation of why this is important?

[Benuuu]

We have line character limits on OnShape. From what I've seen. Pros:

1. Looks nicer
2. It makes assistant editor much more friendly

Cons: You have to make so many more spacing rules.

• Parameter blocks are already indented significantly. What do you do about these when you can't even declare a variable.
• Xcode will try to align colons for you and our typical convention is to put each parameter on a newline or all on the same line. What do you do for a method like - (void)tableView:(UITableView )tableView didEndDisplayingHeaderView:(UIView )view forSection:(NSInteger)section; where the colons cannot align.
• What do you do when you're declaring a property where the init cannot fit on the same line? MYCollectionViewLayout *myCollectionViewLayout = [[MYCollectionViewLayout alloc] initWithSomeReallyLongPropertyName:longPropertyGoesHere]

[cprime]

We certainly can remove this requirement. The community seems pretty split on this one.

When a block appears as a method parameter and the function call requires multiple lines, favor colon aligning the parameters and bringing the block's opening brace onto its own line:

[[RMHTTPClient sharedHTTPClient] discardJob:job
                                     completion:^(NSError *errorOrNil)
    {
        if (errorOrNil) {
            if (completion) {
                completion(errorOrNil);
            }
        } else {
            [self deleteJobs:@[job]];

            if (completion) {
                completion(nil);
            }
        }
    }];

When a method's signature requires multiple lines but impossible to do so, favor bringing the problem parameters as far over as you can.

- (void)tableView:(UITableView *)tableView
didEndDisplayingHeaderView:(UIView *)view
       forSection:(NSInteger)section {
    // CODE
}

When declaring a variable, favor aligning colons followed by breaking at equals:

MYCollectionViewLayout *myCollectionViewLayout = [[MYCollectionViewLayout alloc] initWithShortBit:shortBit
                                                                                             otherBit:otherBit];

MYCollectionViewLayout *myCollectionViewLayout =
    [[MYCollectionViewLayout alloc] initWithSomeReallyLongPropertyName:longPropertyGoesHere];

(Note: this dialog box seems to mess up my spacing from Xcode)